Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mac_os:(launcher) run at boot #913

Merged
merged 1 commit into from
Feb 5, 2020
Merged

mac_os:(launcher) run at boot #913

merged 1 commit into from
Feb 5, 2020

Conversation

afiune
Copy link

@afiune afiune commented Feb 3, 2020 •
edited
Loading

Description

This change has a dependency on chef/chef-workstation-app#153 and once it is
merged it will enable the Chef Workstation App to be run at boot by leveraging
the new chef_workstation_app_launcher script.

Related Issue

#819

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

@afiune afiune added Type: Enhancement Adds new functionality. Aspect: Stability Consistent results. Platform: macOS Triage: Feature Request Indicates an issue requesting new functionality. labels Feb 3, 2020
@afiune afiune requested review from a team as code owners February 3, 2020 22:41
@afiune afiune self-assigned this Feb 3, 2020
@afiune afiune force-pushed the afiune/mac_os/app_launcher branch from aaf55ba to 0928108 Compare February 3, 2020 22:46
@afiune
Copy link
Author

afiune commented Feb 4, 2020

Launched an ad hoc build but for some reason the MacOS packages are not being
tagged correctly so I can't find the correct package, I am trying to build locally now.

@afiune
Copy link
Author

afiune commented Feb 4, 2020

With the previous commit 1637621 now the ad hoc build is passing

cc/ @jonsmorrow

tenor-27588711

@afiune afiune force-pushed the afiune/mac_os/app_launcher branch from 1637621 to ea01ffd Compare February 5, 2020 23:41
mac_os:(launcher) run at boot
29a090e 
This change has a dependency to chef/chef-workstation-app#153

Signed-off-by: Salim Afiune <afiune@chef.io>
@afiune afiune force-pushed the afiune/mac_os/app_launcher branch from 390281e to 29a090e Compare February 5, 2020 23:45
@jonsmorrow jonsmorrow merged commit aed2f69 into master Feb 5, 2020
@chef-expeditor chef-expeditor bot deleted the afiune/mac_os/app_launcher branch February 5, 2020 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonsmorrow jonsmorrow jonsmorrow approved these changes

Assignees

@afiune afiune

Labels
Aspect: Stability Consistent results. Platform: macOS Triage: Feature Request Indicates an issue requesting new functionality. Type: Enhancement Adds new functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@afiune @jonsmorrow