[SHACK-154] Create and run with a config file #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Seth Thomas <sthomas@chef.io>
marcparadise
approved these changes
Apr 20, 2018
|
Thanks for taking this one, it was getting hairier by the PR. |
tyler-ball
suggested changes
Apr 20, 2018
| EOM | ||
|
|
||
| begin | ||
| config_file = Tempfile.new |
There was a problem hiding this comment.
We need to be deleting this Tempfile afterwords - an ensure block with config_file.unlink?
Signed-off-by: Seth Thomas <sthomas@chef.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves to using a config file
workstation.rbinstead of continuing to add CLI options. Also setting sensible defaults for chef-client'scache_pathto ensure we don't step on regular chef-client.As part of this some code moved around so we can upload the config and recipe file independently - this will go away in the future when we move to a bundle but for the time being is cleaner code. I'm not thrilled at what PATH_MAPPING is turning into but we can fix that separately.
Signed-off-by: Seth Thomas sthomas@chef.io