Remove cucumber, dco, knife-spork #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robbkidd
reviewed
Jul 18, 2019
components/gems/Gemfile
Outdated
| @@ -81,7 +81,6 @@ group(:omnibus_package) do | |||
| gem "net-ssh", ">= 4.2.0" | |||
| gem "test-kitchen", ">= 2.0" | |||
| gem "listen" | |||
| gem "dco" # TODO - dksplit - Planned for removal | |||
There was a problem hiding this comment.
I know that many (most? all?) of the Workstation project maintainers probably have git configured to do the commit sign-offs. I'm not so sure about the rest of the community. Did I miss some conversations about its utility?
There was a problem hiding this comment.
The dco gem was included undocumented to ease the transition to the DCO process; the initial blog post details the instructions for configuring git and signing commits, but does not refer anyone to the dco tool to manage this.
Given that the transition to DCO has gone smoothly, and the tool itself is not publicized in DK, there seems little value in continuing to maintain it in Workstation.
robbkidd
approved these changes
Jul 19, 2019
2cfd59a to
a704f78
Compare
|
This bump to chef-cli should see verification passing. |
Signed-off-by: Marc A. Paradise <marc.paradise@gmail.com>
Don't appbundle dco, since we're not pulling the gem anymore. Signed-off-by: Marc A. Paradise <marc.paradise@gmail.com>
Signed-off-by: Marc A. Paradise <marc.paradise@gmail.com>
After removing our dependency on the cucumber gem, the development versions of cucumber in TK and berkshelf were causing cascading appbundler dep failures. It seems to have caused TK and berkshelf to pull in a version of `cucumber` that was incompatible with the `cucumber-core` required by foodcritic (not in dev mode). `--without development` for TK and berkshelf prevents the full version of `cucumber` from getting pulled in at all. Signed-off-by: Marc A. Paradise <marc.paradise@gmail.com>
Signed-off-by: Marc A. Paradise <marc.paradise@gmail.com>
25bd57d to
d9de144
Compare
tas50
approved these changes
Jul 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tools are not used by Workstation, and do not fit into any recommended workflow.
Signed-off-by: Marc A. Paradise marc.paradise@gmail.com