Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SHACK-107] Specify resource attributes on command line #33

Merged
merged 2 commits into from
Mar 29, 2018

Conversation

tyler-ball
Copy link
Contributor

This adds support and documentation for users specifying resource
attributes. These can be specified as "key=value" optional args after
the resource type/name.

@tyler-ball tyler-ball requested a review from a team March 28, 2018 22:13
@tyler-ball tyler-ball force-pushed the SHACK-107/attributes branch from e9f47d6 to 566c7cf Compare March 28, 2018 22:14
Copy link
Contributor

@jonsmorrow jonsmorrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me

Copy link
Member

@marcparadise marcparadise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! +1 once the exceptions are updated

This adds support and documentation for users specifying resource
attributes. These can be specified as "key=value" optional args after
the resource type/name.

Signed-off-by: tyler-ball <tyleraball@gmail.com>
@tyler-ball tyler-ball force-pushed the SHACK-107/attributes branch from 566c7cf to 90629ef Compare March 29, 2018 18:45
@tyler-ball tyler-ball merged commit b72e88d into master Mar 29, 2018
@tyler-ball tyler-ball deleted the SHACK-107/attributes branch March 29, 2018 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants