Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subscribe to Workstation App pr merges #255

Merged
merged 1 commit into from
Oct 10, 2018
Merged

Subscribe to Workstation App pr merges #255

merged 1 commit into from
Oct 10, 2018

Conversation

jonsmorrow
Copy link
Contributor

@jonsmorrow jonsmorrow commented Oct 10, 2018 •
edited
Loading

Description

This change attempts to subscribe to merge events
on chef/chef-workstation-app and use that to manage
our dependency on the project.

Check List

  • PR title is a worthy inclusion in the CHANGELOG
  • You have locally validated the change
  • www/site/content/docs/ has been updated with any relevant changes:
      • new or changed error messages in 'troubleshooting.md'
      • new or changed CLI flags in cli-reference.md

@jonsmorrow jonsmorrow requested a review from a team October 10, 2018 20:54
marcparadise
marcparadise approved these changes Oct 10, 2018
View reviewed changes
Copy link
Member

@marcparadise marcparadise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jonsmorrow jonsmorrow force-pushed the JM/manage_workstation_app_version branch 2 times, most recently from f338378 to 3799765 Compare October 10, 2018 21:05
tyler-ball
tyler-ball approved these changes Oct 10, 2018
View reviewed changes
Copy link
Contributor

@tyler-ball tyler-ball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well you already fixed the two things I was going to make a comment about 😁

.expeditor/update_chef-workstation-app_to_latest.sh Outdated

set -evx

version=$(get_github_file $SCM_SETTINGS_GITHUB_REPO master VERSION)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this script is pretty hard-coded now, why don't we just use get_github_file chef-workstation-app master VERSION instead of having that be dynamic. Is more straightforward that way, but less flexible if we modify this in the future

Subscribe to Workstation App pr merges
44cb95b 
This change attempts to subscribe to merge events
on chef/chef-workstation-app and use that to manage
our dependency on the project.

Signed-off-by: Jon Morrow <jmorrow@chef.io>
@jonsmorrow jonsmorrow force-pushed the JM/manage_workstation_app_version branch from 3799765 to 44cb95b Compare October 10, 2018 21:06
@jonsmorrow jonsmorrow merged commit f33ab66 into master Oct 10, 2018
@chef-ci chef-ci deleted the JM/manage_workstation_app_version branch October 10, 2018 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcparadise marcparadise marcparadise approved these changes

@tyler-ball tyler-ball tyler-ball approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonsmorrow @marcparadise @tyler-ball