Fix error that occurs when config file deleted. #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the default ocnfiguration file is deleted, and a custom file is not specified, chef-run emits a stack trace due to failure loading the missing file. This can happen when the customer deletes or removes the default config.toml. chef-run creates the file only on first-run, so if it's removed after that point it stays gone. Because we have to assume the customer had a reason for deleting the configuration file, we can't recreate a new empty file. Instead, this fix changes it so that if the config file is missing, we don't try to load it. This will leave configuration defaults in place. Signed-off-by: Marc A. Paradise <marc.paradise@gmail.com>
cheeseplus
approved these changes
Jun 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Marc A. Paradise marc.paradise@gmail.com
Description
When the default configuration file is deleted, and
a custom file is not specified, chef-run emits a stack trace
due to failure loading the missing file.
This can happen when the customer deletes or removes the default
config.toml. chef-run creates the file only on first-run, so if it's
removed after that point it stays gone.
Because we have to assume the customer had a reason for deleting the
configuration file, we can't recreate a new empty file. Instead,
this fix changes it so that if the config file is missing, we don't try
to load it. This will leave configuration defaults in place.
Issues Resolved
Check List