Fix Homebrew PR creation #1413
Merged
Fix Homebrew PR creation #1413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* switch to the macos executor, because the non-ES linuxbrew image is not a permitted to access expeditor secrets. * Updates buildkite emoji alias to be :mac: * mac-compatibility fixes for sed usage. * Fix PR request to set maintainer_can_modify to false. This otherwise fails the PR with a message about the non-existent field `fork_collab`, possibly because the account creating the branch (chef-ci) doesn't have proper push access to the branch, triggering an odd validation failure from GH API. Ref: octokit/rest.js#490 * fix indentation issue in third party package pipeline yml (tball, squashed) Signed-off-by: Marc A. Paradise <marc.paradise@gmail.com>
|
Deploy preview for chef-workstation ready! Built with commit 2bef9d1 |
|
Testing result , shows the created PR in my temp repo homebrew-cask-autotesting
|
tyler-ball
approved these changes
Aug 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not a permitted to access expeditor secrets.
fails the PR with a message about the non-existent field
fork_collab, possibly because the account creating the branch(chef-ci) doesn't have proper push access to the branch, triggering
an odd validation failure from GH API. Ref: build(deps): Bump send and express in /docs octokit/rest.js#490
squashed)
Signed-off-by: Marc A. Paradise marc.paradise@gmail.com