Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Foodcritic to 16.3 to remove gherkin/cucumber/backports #1277

Merged
merged 1 commit into from
Jun 22, 2020

Conversation

tas50
Copy link
Contributor

@tas50 tas50 commented Jun 22, 2020

Nukes a large pile of deps and slims down the app a bit.

backports 671 files / 2.5MB on disk
gherkin: 23 files / 209k on disk
cucumber-core: 55 files / 221k on disk
cucumber-tag-expressions: 10 files / 25k on disk

~3 megs shaved off the install and 759 files

Signed-off-by: Tim Smith tsmith@chef.io

Aha! Link: https://chef.aha.io/features/SH-2361

Nukes a large pile of deps and slims down the app a bit.

backports 671 files / 2.5MB on disk
gherkin: 23 files / 209k on disk
cucumber-core: 55 files / 221k on disk
cucumber-tag-expressions: 10 files / 25k on disk

~3 megs shaved off the install and 759 files

Signed-off-by: Tim Smith <tsmith@chef.io>
@tas50 tas50 requested review from a team as code owners June 22, 2020 19:18
@netlify
Copy link

netlify bot commented Jun 22, 2020

Deploy preview for chef-workstation ready!

Built with commit 372e3d2

https://deploy-preview-1277--chef-workstation.netlify.app

Copy link
Member

@marcparadise marcparadise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woot! I've been wanting to hunt down the cucumber bits forever. I remember running into complications running verification though, hopefully those aren't still a thing. I'm good to merge after a passing ad-hoc omnibus pipeline run.

@tas50 tas50 merged commit 8e9f13b into master Jun 22, 2020
@chef-expeditor chef-expeditor bot deleted the slim_foodcritic branch June 22, 2020 22:44
@jonsmorrow jonsmorrow added the Epic label Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants