Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add buildfuture to make commands #1202

Merged
merged 3 commits into from
May 27, 2020
Merged

Add buildfuture to make commands #1202

merged 3 commits into from
May 27, 2020

Conversation

IanMadd
Copy link
Contributor

@IanMadd IanMadd commented May 15, 2020

Signed-off-by: IanMadd imaddaus@chef.io

Description

We can set a publishDate value to a new page and then it won't get displayed in docs.chef.io even if it's merged and we update the chef-workstation module on docs.chef.io. But new pages won't show up in previews on Netlify or locally if the publish date is in the future.

This adds the buildfuture option to build commands so we can see new pages when we preview with Netlify or locally.

Also adds a publishDate parameter to the default archetype page.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

Aha! Link: https://chef.aha.io/features/SH-1928

Signed-off-by: IanMadd <imaddaus@chef.io>
@IanMadd IanMadd added the Aspect: Documentation How do we use this project? label May 15, 2020
@IanMadd IanMadd requested a review from kagarmoe May 15, 2020 20:33
@IanMadd IanMadd requested review from a team as code owners May 15, 2020 20:33
@netlify
Copy link

netlify bot commented May 15, 2020

Deploy preview for chef-workstation ready!

Built with commit 60d1c47

https://deploy-preview-1202--chef-workstation.netlify.app

Copy link

@kagarmoe kagarmoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tenor-209827557

@tyler-ball tyler-ball merged commit 489f7e1 into master May 27, 2020
@chef-expeditor chef-expeditor bot deleted the im/buildfuture branch May 27, 2020 01:15
@jonsmorrow jonsmorrow added Epic and removed Aspect: Documentation How do we use this project? labels Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants