Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding gen for dist, using dist in the executables #1087

Merged
merged 5 commits into from
Apr 15, 2020
Merged

adding gen for dist, using dist in the executables #1087

merged 5 commits into from
Apr 15, 2020

Conversation

tarcinil
Copy link
Contributor

@tarcinil tarcinil commented Apr 10, 2020 •
edited by jonsmorrow
Loading

Signed-off-by: Vern Burton me@vernburton.com

Description

This moves executables for subcommands to be configurable.

Related Issue

#1086

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

Aha! Link: https://chef.aha.io/features/SH-1342

@tarcinil
adding gen for dist, using dist in the executables
ff9a42d 
Signed-off-by: Vern Burton <me@vernburton.com>
@tarcinil tarcinil requested review from a team as code owners April 10, 2020 00:32
@tarcinil
Copy link
Contributor Author

This has a dependency on chef/go-libs#26

@tyler-ball
Copy link
Contributor

@tarcinil I merged chef/go-libs#26 and released go-libs v0.4.0 so you should be able to consume that here

@tyler-ball tyler-ball merged commit a1f6dd6 into chef:master Apr 15, 2020
@tyler-ball tyler-ball mentioned this pull request Apr 15, 2020
Closed
@jonsmorrow jonsmorrow added the Epic label Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyler-ball tyler-ball tyler-ball approved these changes

Assignees
No one assigned
Labels
Epic
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tarcinil @tyler-ball @jonsmorrow