Added warning if input of vault admin is other than array #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tas50
reviewed
Jul 29, 2020
lib/chef/knife/vault_admins.rb
Outdated
| @@ -26,6 +26,10 @@ def admins | |||
| vault_admins = Chef::Config[:knife][:vault_admins] | |||
| admin_array = [Chef::Config[:node_name]] | |||
|
|
|||
| if !vault_admins.kind_of?(Array) | |||
| + ui.warn("Vault admin is needed to be input as an array") | |||
There was a problem hiding this comment.
Suggested change
| + ui.warn("Vault admin is needed to be input as an array") | |
| + ui.warn("Vault admin must be an array") |
There was a problem hiding this comment.
@tas50 will update it, thanks
Signed-off-by: sanga17 <sausekar@msystechnologies.com>
Signed-off-by: sanga17 <sausekar@msystechnologies.com>
a4ec17b to
3c739c3
Compare
|
Thanks @sanga1794 |
|
Having an issue calling this from the Windows command line - If I try to use -A with any kind of parameter it always now complains that "Vault admin must be an array". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: sanga17 sausekar@msystechnologies.com
Description
Added warning if input of vault admin is other than array
Related Issue
Fixed: #219
Types of changes
Checklist: