-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added note in documentation regarding the vault item name #349
Added note in documentation regarding the vault item name #349
Conversation
Signed-off-by: sanga17 <sausekar@msystechnologies.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"then the whole VAULT will move in data_bag list instead of vault."
I don't think that comment will be clear enough. "move in" doesn't really express what happens.
Maybe "then the vault item will be treated as an ordinary data_bag instead of as a vault."
Thanks @MarkGibbons for suggestions, will update it. |
Signed-off-by: sanga17 <sausekar@msystechnologies.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Picky copy edits.
Co-authored-by: Kimberly Garmoe <kgarmoe@chef.io>
Signed-off-by: sanga17 <sausekar@msystechnologies.com>
…e_parser' of github.com:MsysTechnologiesllc/chef-vault into sangmeshA/Fix_ending_data_bag_item_names_in_confuses_the_parser
@kagarmoe Please check ^ |
Signed-off-by: sanga17 sausekar@msystechnologies.com
Description
Fixed ending data bag item names in '_keys' confuses the the parser
Related Issue
Fixed: #228
Types of changes
Checklist: