Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added note in documentation regarding the vault item name #349

Conversation

sanga1794
Copy link
Contributor

@sanga1794 sanga1794 commented Jun 9, 2020

Signed-off-by: sanga17 sausekar@msystechnologies.com

Description

Fixed ending data bag item names in '_keys' confuses the the parser

Related Issue

Fixed: #228

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits have been signed-off for the Developer Certificate of Origin.

Signed-off-by: sanga17 <sausekar@msystechnologies.com>
@sanga1794 sanga1794 requested a review from a team as a code owner June 9, 2020 07:59
@sanga1794 sanga1794 changed the title Added note in documentation regarding the vault item name WIP: Added note in documentation regarding the vault item name Jun 9, 2020
Copy link
Contributor

@MarkGibbons MarkGibbons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"then the whole VAULT will move in data_bag list instead of vault."

I don't think that comment will be clear enough. "move in" doesn't really express what happens.
Maybe "then the vault item will be treated as an ordinary data_bag instead of as a vault."

@sanga1794
Copy link
Contributor Author

"then the whole VAULT will move in data_bag list instead of vault."

I don't think that comment will be clear enough. "move in" doesn't really express what happens.
Maybe "then the vault item will be treated as an ordinary data_bag instead of as a vault."

Thanks @MarkGibbons for suggestions, will update it.

Signed-off-by: sanga17 <sausekar@msystechnologies.com>
@sanga1794 sanga1794 changed the title WIP: Added note in documentation regarding the vault item name Added note in documentation regarding the vault item name Jun 10, 2020
README.md Outdated Show resolved Hide resolved
Copy link

@kagarmoe kagarmoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Picky copy edits.

sanga1794 and others added 3 commits June 11, 2020 09:49
Co-authored-by: Kimberly Garmoe <kgarmoe@chef.io>
Signed-off-by: sanga17 <sausekar@msystechnologies.com>
…e_parser' of github.com:MsysTechnologiesllc/chef-vault into sangmeshA/Fix_ending_data_bag_item_names_in_confuses_the_parser
@dheerajd-msys
Copy link

@kagarmoe Please check ^

@tas50 tas50 merged commit d158946 into chef:master Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ending data bag iten names in '_keys' confusese the the parser
5 participants