Don't consider opscode-chef-mover service status when checking ha-status

[poliva83]

Obvious fix for #361

[stevendanna]

We may want to use omnibus-ctl's concept of hidden services here. In that case, this check would become:

next if hidden_services.include?(service_name)

[stevendanna]

Thanks! This is a good improvement, I left a minor comment about using the hiddent_services array that omnibus-ctl already provides.

[poliva83]

@stevendanna I can change the PR to use hidden_services array. But can you please explain to me how this array becomes available to the ha.rb script?

The only reference to it I found is here:

chef-server/omnibus/files/private-chef-cookbooks/private-chef/attributes/default.rb

Line 24 in 003067d

opscode-chef-mover

But to be perfectly honest I didn't really understand how ha.rb script was able to leverage the get_all_services array either.

[stevendanna]

@poliva83 Happy to try to explain.

TL;DR: You have access to any instance method in the Omnibus::Ctl class.

When we load a command definition like ha.rb, an instance of
Omnibus::Ctl eval's the relevant file:

https://github.com/chef/omnibus-ctl/blob/master/lib/omnibus-ctl.rb#L172-L174

The add_command_under_category function used to define new
commands, is actually a methods on the Omnibus::Ctl class. It
uses the block provided to add_command_under_category to define a
new instance method the Omnibus::ctl class:

https://github.com/chef/omnibus-ctl/blob/master/lib/omnibus-ctl.rb#L190

That new instance method, like any other instance method in that
class, has access to all other the other methods already defined
in Omnibus::Ctl.

Both hidden_services and get_all_services are instance methods in
the Omnibus::Ctl class

https://github.com/chef/omnibus-ctl/blob/master/lib/omnibus-ctl.rb#L320
https://github.com/chef/omnibus-ctl/blob/master/lib/omnibus-ctl.rb#L397

which is why you have access to them here.

[poliva83]

@stevendanna Thanks for explanation, things are more clear now. I tested and updated my pull request. Should be good now.

[stevendanna]

:+1 This looks good to merge.