[POOL-589] Add regexp for {first, middle, last, display}name #1294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srenatus
commented
Jun 6, 2017
| {?VD(lists:flatten(io_lib:format("Works with non-ASCII ~s", [Field]))), | ||
| fun() -> | ||
| %% "Maryam", #1 female name in the arab world as of 2015 | ||
| Value = <<"مريم 1. O'Mara">>, |
There was a problem hiding this comment.
Interesting. Must have to do with my editor not knowing right-to-left text, because it looks different there:
marcparadise
approved these changes
Jun 7, 2017
|
I'll merge this rebase + travis re-run passes - looks like our authz connection pool ran out in CT on the last run. |
marcparadise
approved these changes
Jun 7, 2017
I've tried to be liberal. What this still forbids is anything html-y, or SQL-y. It's probably not even close to capturing real-world names. Signed-off-by: Stephan Renatus <srenatus@chef.io>
a2ff439 to
943c5f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've tried to be liberal. What this still forbids is anything html-y, or
SQL-y. It's probably not even close to capturing real-world names.