Merge pull request #606 from chef/dp_nil_username_ocid

nil username breaks Analytics login
chef · Nov 4, 2015 · fa1f66f · fa1f66f
2 parents f2ad735 + ae8b9ec
commit fa1f66f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/src/oc-id/app/models/user.rb b/src/oc-id/app/models/user.rb
@@ -126,7 +126,7 @@ def admin?(username)
 
     def find(username)
       begin
-        if (username.include?('@'))
+        if (username != nil && username.include?('@'))
           users = self.new.chef.get(
             "users?#{{ email: username }.to_query}"
           )

diff --git a/src/oc-id/spec/models/user_spec.rb b/src/oc-id/spec/models/user_spec.rb
@@ -60,6 +60,10 @@
     expect(User.find(jimmy.email)).to eql(jimmy)
   end
 
+  it 'doesnt blow up when user is nil' do
+    expect(User.find(nil)).to be_nil
+  end
+
   describe 'updating a password' do
     fields = [:current_password, :new_password, :password_confirmation]
     fields.each do |f|