Decouple chef-client installation for windows - using omnitruck API #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll be really interested to see how this affects download and install time -- let's make sure we don't regress such that we can't get chef installed in time. There is work being done to speed up chef-client installations which will benefit us very soon |
|
@adamedx - Tested with internal publish is not affecting download and install time. |
| @@ -48,7 +48,7 @@ function Get-SharedHelper { | |||
| } | |||
|
|
|||
| function Get-LocalDestinationMsiPath($chefExtensionRoot) { | |||
There was a problem hiding this comment.
I think we can remove argument $chefExtensionRoot here ?
added 4 commits
October 19, 2015 14:07
e63909f to
865e793
Compare
NimishaS
pushed a commit
that referenced
this pull request
Oct 19, 2015
…hef_client_install Decouple chef-client installation for windows - using omnitruck API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.