MSYS-548 - Fixed failing extension for service startmode is disabled. #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9ea2237 to
fd776c4
Compare
Signed-off-by: piyushawasthi <piyush.awasthi@msystechnologies.com>
fd776c4 to
1bf48b0
Compare
NimishaS
suggested changes
Jun 29, 2017
lib/chef/azure/service.rb
Outdated
| @@ -117,6 +117,7 @@ def is_running? | |||
| def start_service(bootstrap_directory, log_location) | |||
| puts "#{Time.now} Starting chef-client service ...." | |||
| params = " -c #{bootstrap_directory}\\client.rb -L #{log_location}\\chef-client.log " | |||
| set_startup_type = %x{powershell.exe -Command "Set-Service -Name 'chef-client' -StartupType automatic"} | |||
There was a problem hiding this comment.
Please check if we can use shell_out instead of %x.
There was a problem hiding this comment.
mixlib-shellout library basically for subprocess management and output collection. Here, we aren't collecting any output so that shell_out is not required for this.
spec/unit/service_spec.rb
Outdated
| @@ -335,6 +335,21 @@ | |||
| end | |||
| end | |||
|
|
|||
| context 'service start successful for startup type is disable' do | |||
| before do | |||
| allow(instance).to receive(%x{powershell.exe -Command "Set-Service -Name 'chef-client' -StartupType Disabled"}).and_return(true) | |||
There was a problem hiding this comment.
This line doesn't execute as we are not calling %x{powershell.exe -Command "Set-Service -Name 'chef-client' -StartupType Disabled"} in the code.
spec/unit/service_spec.rb
Outdated
| allow(instance).to receive(%x{powershell.exe -Command "Set-Service -Name 'chef-client' -StartupType Disabled"}).and_return(true) | ||
| end | ||
| it 'does not report any error' do | ||
| allow(instance).to receive(%x{powershell.exe -Command "Set-Service -Name 'chef-client' -StartupType automatic"}) |
c6bec69 to
5d73e5c
Compare
NimishaS
approved these changes
Jul 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will make sure that Azure Chef extension start the chef-client service, If service StartMode is disabled.