Skip to content
This repository has been archived by the owner on Jun 28, 2018. It is now read-only.

WIP: Turn build-install-test into locally-runnable Chef recipes #286

Closed
wants to merge 30 commits into from

Conversation

randomcamel
Copy link
Contributor

No description provided.

Chris Doherty added 30 commits October 8, 2014 14:09
…rwrite /etc/sudoers and set some environment variables.
fetcher_read_timeout 120
# -----------------------------------------

ENV['USE_LOCAL_CHEF'] ||= "/home/vagrant/chef"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nuke this file, it's already set in build-pkg.rb.

@lamont-granquist
Copy link
Contributor

It'd be a lot better to put the effort into test-kitchen and fixing the "support multiple provisioners run in sequence" aspect of:

test-kitchen/test-kitchen#329

most of your cookbook is a glorified bash script with bash resources and execute resources. it should just be a chained shell provisioner.

most of the code in ruby_blocks and the lazy attributes looks like it can be removed. i can't tell why you start down that road to suggest what to fix.

at this point all these files really need to be moved to their own directory more like the tk tests in the chef project itself. for awhile just having the .kitchen.yml in the root directory here was nice, but if you're going to add this much complexity to the test platform it needs to be isolated in its own subdirectory. i'd actually suggest that this cookbook needs to be ripped out and stand on its own outside of this repository.

@randomcamel randomcamel changed the title Turn build-install-test into locally-runnable Chef recipes WIP: Turn build-install-test into locally-runnable Chef recipes Nov 11, 2014
@randomcamel
Copy link
Contributor Author

Seth had similar thoughts about pulling it out of here--clearly this requires some better structure. The resemblance to a giant bash script isn't an accident, since the intention was to take the Jenkins build-test sequence (written in bash) and be able to run it locally on both Unix and Windows guests. The changes to the Jenkins scripts are now moot, anyway, and the PR was just so Seth could look at the diff.

This is as far as it goes at the moment: both chef_omnibus_install_options and chef_omnibus_install_root are only supported in TK master and not the current 1.2.1 release, and TK+Windows is a WIP, so that's where our attention is going next.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants