Skip to content
This repository has been archived by the owner on Jul 14, 2021. It is now read-only.

Update default platforms for generated kitchen.yml #382

Closed
wants to merge 1 commit into from

Conversation

jtimberman
Copy link
Contributor

  • Ubuntu 14.04 is now a year old
  • CentOS 6.6 is the current 6.x release

@tyler-ball
Copy link
Contributor

I like the idea of using Ubuntu 14.04 because that is an LTS release, but can you update Centos to use centos-7.1 since that is the latest Centos release?

@jtimberman
Copy link
Contributor Author

@tyler-ball doneburger!

@danielsdeleo
Copy link
Contributor

👍 LGTM

@jtimberman
Copy link
Contributor Author

Actually, houston, we have a problem. centos-7.1 is not automatically detected by kitchen-vagrant.

https://github.com/test-kitchen/kitchen-vagrant/blob/master/lib/kitchen/driver/vagrant.rb#L194-L200

@jtimberman
Copy link
Contributor Author

Related issue: test-kitchen/kitchen-vagrant#165

@jtimberman
Copy link
Contributor Author

There's two approaches.

  1. Use centos-7.0.
  2. Use centos-7.1 but specify the box name, a la
- name: centos-7.1
  driver_config:
    box: opscode-centos-7.1

Either way, kitchen-vagrant should get updated.

@danielsdeleo
Copy link
Contributor

The second option looks better to me for now.

@jtimberman jtimberman force-pushed the jtimberman/update-kitchen-platforms branch from 1dde2c2 to f12a895 Compare May 7, 2015 16:55
fnichol added a commit to test-kitchen/kitchen-vagrant that referenced this pull request May 7, 2015
This update attempts to improve on
a2ef401 which remains a workaround
until the work of continuously publishing Bento boxes to Atlas is
completed.

The rationale and rules in the above mentioned commit remain, but now
only the platform name is checked. In other words, if the platform name
begins with one of the following (case-sensitive):

* `centos`
* `debian`
* `fedora`
* `freebsd`
* `opensuse`
* `ubuntu`

then the platform is assumed to have a Bento box, hosted in the
pre-determined S3 bucket.

References #165
References test-kitchen/test-kitchen#707
References test-kitchen/test-kitchen#663
References chef-boneyard/chef-dk#382
References chef-boneyard/chef-dk#378
@fnichol
Copy link
Contributor

fnichol commented May 7, 2015

Just added the PR in kitchen-vagrant above to match the following platform names:

  • centos
  • debian
  • fedora
  • freebsd
  • opensuse
  • ubuntu

Any name starting with those strings will be assumed to have a Bento box, so will prepend "opscode-" for :box and will compute a :box_url for VirtualBox and VMware providers. We'll get that released ASAP as a sideways mitigation and I'll follow up with a PR to test-kitchen/test-kitchen to update kitchen init with the same platform defaults.

fnichol added a commit to test-kitchen/test-kitchen that referenced this pull request May 7, 2015
The updated platforms are:

- ubuntu-14.04
- centos-7.1

References #707
References #663
References chef-boneyard/chef-dk#382
References chef-boneyard/chef-dk#378
fnichol added a commit to test-kitchen/test-kitchen that referenced this pull request May 7, 2015
The updated platforms are:

- ubuntu-14.04
- centos-7.1

References #707
References #663
References chef-boneyard/chef-dk#382
References chef-boneyard/chef-dk#378
@tyler-ball
Copy link
Contributor

@jtimberman with @fnichol's updates, can you restore this to just 14.04 and 7.1?

- Ubuntu 14.04 is now a year old
- CentOS 7.1 is the current 7.x release; 7.x is the current CentOS release

This will require kitchen-vagrant 0.18.0.
@jtimberman jtimberman force-pushed the jtimberman/update-kitchen-platforms branch from f12a895 to 5935b1e Compare May 8, 2015 04:59
@jtimberman
Copy link
Contributor Author

@tyler-ball Sure thing, latest push has that.

@danielsdeleo
Copy link
Contributor

@tyler-ball have we done all the omnibus stuff to make sure the required kitchen fix will be in the omnibus package? 👍 to merge once that's done.

@tyler-ball
Copy link
Contributor

@danielsdeleo chef-boneyard/omnibus-chef#390

👍 to this

danielsdeleo added a commit that referenced this pull request Jun 1, 2015
@danielsdeleo
Copy link
Contributor

Closed as ac63468

@danielsdeleo danielsdeleo deleted the jtimberman/update-kitchen-platforms branch June 1, 2015 22:35
ksubrama pushed a commit that referenced this pull request Jan 11, 2016
Preping for ChefDK 0.5.1 release
@chef-boneyard chef-boneyard locked and limited conversation to collaborators Feb 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants