Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zdtm/static/pidfd_dead fails in Fedora Rawhide: #2490

Closed
avagin opened this issue Oct 8, 2024 · 0 comments · Fixed by #2491
Closed

zdtm/static/pidfd_dead fails in Fedora Rawhide: #2490

avagin opened this issue Oct 8, 2024 · 0 comments · Fixed by #2491

Comments

@avagin
Copy link
Member

avagin commented Oct 8, 2024 

          It looks like this test fails in Fedora Rawhide:

======================= Run zdtm/static/pidfd_dead in h ========================
Start test
./pidfd_dead --pidfile=pidfd_dead.pid --outfile=pidfd_dead.out
Run criu dump
Run criu restore
=[log]=> dump/zdtm/static/pidfd_dead/168/1/restore.log
------------------------ grep Error ------------------------
b'(00.004951)    168: \t\t\tGoing to dup 1 into 2'
b'(00.004953)    168: \tReceive fd for 2'
b'(00.004961)    168: \t\tCreate fd for 3'
b'(00.005264)    168: \t\tCreate fd for 4'
b'(00.005486)    168: Error (criu/cr-restore.c:1261): 175 killed by signal 9: Killed'
b'(00.005504) Error (criu/cr-restore.c:2314): Restoring FAILED.'
------------------------ ERROR OVER ------------------------
############### Test zdtm/static/pidfd_dead FAIL at CRIU restore ###############
Test output: ================================

https://github.com/checkpoint-restore/criu/runs/31040419148

Originally posted by @rst0git in #2449 (comment)
rst0git pushed a commit to rst0git/criu that referenced this issue Oct 9, 2024
@bsach64 @rst0git
pidfd: block SIGCHLD during tmp process creation
9520e36 
This patch blocks SIGCHLD during temporary process creation to prevent a
race condition between kill() and waitpid() where sigchld_handler()
causes `criu restore` to fail with an error.

Fixes: checkpoint-restore#2490

Signed-off-by: Bhavik Sachdev <b.sachdev1904@gmail.com>
Signed-off-by: Radostin Stoyanov <rstoyanov@fedoraproject.org>
@rst0git rst0git mentioned this issue Oct 9, 2024
Merged
rst0git pushed a commit to rst0git/criu that referenced this issue Oct 9, 2024
@bsach64 @rst0git
pidfd: block SIGCHLD during tmp process creation
1543b4a 
This patch blocks SIGCHLD during temporary process creation to prevent a
race condition between kill() and waitpid() where sigchld_handler()
causes `criu restore` to fail with an error.

Fixes: checkpoint-restore#2490

Signed-off-by: Bhavik Sachdev <b.sachdev1904@gmail.com>
Signed-off-by: Radostin Stoyanov <rstoyanov@fedoraproject.org>
rst0git pushed a commit to rst0git/criu that referenced this issue Oct 9, 2024
@bsach64 @rst0git
pidfd: block SIGCHLD during tmp process creation
794f5e3 
This patch blocks SIGCHLD during temporary process creation to prevent a
race condition between kill() and waitpid() where sigchld_handler()
causes `criu restore` to fail with an error.

Fixes: checkpoint-restore#2490

Signed-off-by: Bhavik Sachdev <b.sachdev1904@gmail.com>
Signed-off-by: Radostin Stoyanov <rstoyanov@fedoraproject.org>
rst0git pushed a commit to rst0git/criu that referenced this issue Oct 14, 2024
@bsach64 @rst0git
pidfd: block SIGCHLD during tmp process creation
2f5e4f5 
This patch blocks SIGCHLD during temporary process creation to prevent a
race condition between kill() and waitpid() where sigchld_handler()
causes `criu restore` to fail with an error.

Fixes: checkpoint-restore#2490

Signed-off-by: Bhavik Sachdev <b.sachdev1904@gmail.com>
Signed-off-by: Radostin Stoyanov <rstoyanov@fedoraproject.org>
rst0git pushed a commit to rst0git/criu that referenced this issue Oct 14, 2024
@bsach64 @rst0git
pidfd: block SIGCHLD during tmp process creation
68c61f1 
This patch blocks SIGCHLD during temporary process creation to prevent a
race condition between kill() and waitpid() where sigchld_handler()
causes `criu restore` to fail with an error.

Fixes: checkpoint-restore#2490

Signed-off-by: Bhavik Sachdev <b.sachdev1904@gmail.com>
Signed-off-by: Radostin Stoyanov <rstoyanov@fedoraproject.org>
rst0git pushed a commit to rst0git/criu that referenced this issue Oct 20, 2024
@bsach64 @rst0git
pidfd: block SIGCHLD during tmp process creation
66f165e 
This patch blocks SIGCHLD during temporary process creation to prevent a
race condition between kill() and waitpid() where sigchld_handler()
causes `criu restore` to fail with an error.

Fixes: checkpoint-restore#2490

Signed-off-by: Bhavik Sachdev <b.sachdev1904@gmail.com>
Signed-off-by: Radostin Stoyanov <rstoyanov@fedoraproject.org>
@avagin avagin closed this as completed in dfb56ee Oct 21, 2024
avagin pushed a commit that referenced this issue Oct 27, 2024
@bsach64 @avagin
pidfd: block SIGCHLD during tmp process creation
d8be857 
This patch blocks SIGCHLD during temporary process creation to prevent a
race condition between kill() and waitpid() where sigchld_handler()
causes `criu restore` to fail with an error.

Fixes: #2490

Signed-off-by: Bhavik Sachdev <b.sachdev1904@gmail.com>
Signed-off-by: Radostin Stoyanov <rstoyanov@fedoraproject.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

pidfd: block SIGCHLD during tmp process creation rst0git/criu
1 participant
@avagin