Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not apply block range filter on internal tables #303

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

Sekhmet
Copy link
Contributor

@Sekhmet Sekhmet commented Jun 26, 2024

This commit also refactors out applyBlockFilter helper into database utils to avoid repetition.

Closes: #301

Test plan

Run query like this:

query ($checkpointId: ID!, $metadataId: ID!) {
  spaces(block: 18407) {
    id
  }
  _checkpoints {
    id
  }
  _metadatas {
    id
  }
  _checkpoint(id: $checkpointId) {
    id
  }
  _metadata(id: $metadataId) {
    id
  }
}

It works without crashing.

This commit also refactors out applyBlockFilter helper into database utils
to avoid repetition.
@Sekhmet Sekhmet requested a review from bonustrack June 26, 2024 19:17
@Sekhmet Sekhmet self-assigned this Jun 26, 2024
Copy link
Contributor

@bonustrack bonustrack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@Sekhmet Sekhmet merged commit 333ca3f into master Jun 26, 2024
1 check passed
@Sekhmet Sekhmet deleted the sekhmet/metadata-apply-block-filter branch June 26, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: _checkpoints entity can not be queried anymore
2 participants