Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for subscription sets [ch16184] #54

Merged
merged 1 commit into from
Sep 23, 2019

Conversation

tommycarney
Copy link
Contributor

This PR allows for support for subscription sets. It adds a subscription_set_external_id attribute to the following objects:

  • ChartMogul\LineItems
  • ChartMogul\Subscription.

@codeclimate
Copy link

codeclimate bot commented Sep 20, 2019

Code Climate has analyzed commit 7bf72df and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 67.1% (0.0% change).

View more on Code Climate.

@pkopac pkopac removed their request for review September 20, 2019 12:31
@pkopac pkopac merged commit ccaef43 into master Sep 23, 2019
@pkopac pkopac deleted the tc/ch16184/subscription-set-support branch September 23, 2019 12:40
tommycarney pushed a commit that referenced this pull request Sep 23, 2019
pkopac pushed a commit that referenced this pull request Sep 23, 2019
* Add support for subcription sets (#54)

* Use trusty distribution to allow 5.5

* Test snippet from master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants