Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fields to AbstractModel #129

Merged

Conversation

swember
Copy link
Contributor

@swember swember commented Jul 2, 2024

Dynamic properties are deprecated in PHP 9. Most of the props are covered in #127 and #128, except of pagination fields.
This PR covers them.

@swember swember requested a review from pkopac July 2, 2024 14:47
Copy link

codeclimate bot commented Jul 2, 2024

Code Climate has analyzed commit 8d803b0 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 75.6%.

View more on Code Climate.

@pkopac pkopac merged commit fd0f489 into main Jul 3, 2024
8 checks passed
@pkopac pkopac deleted the dmitriydavydov/sc-60519/add-missing-pagination-props-to-php-lib branch July 3, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants