Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove support for page query params #115

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

kmossco
Copy link

@kmossco kmossco commented Oct 31, 2023

After we released v5.1.3 to add support for the cursor based pagination, this new version removes that support and will throw an error if the page pagination parameter is used.

Signed-off-by: Bruno Vieira <bruno@chartmogul.com>
@kmossco kmossco requested review from daesu and sbrych October 31, 2023 08:16
@kmossco kmossco self-assigned this Oct 31, 2023
@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #51957: [PHP] Add support for new pagination to client libs.

@codeclimate
Copy link

codeclimate bot commented Oct 31, 2023

Code Climate has analyzed commit 1503f3a and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 75.5%.

View more on Code Climate.

Copy link
Contributor

@sbrych sbrych left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@kmossco
Copy link
Author

kmossco commented Oct 31, 2023

Merging this even with the coding guidelines failure, because I try to run it locally and I don't get the same error as in the action:

➜  chartmogul-php git:(sc-51957/deprecate_old_pagination) ./vendor/bin/php-cs-fixer check src/
Loaded config default.
Using cache file ".php-cs-fixer.cache".

Found 0 of 88 files that can be fixed in 0.001 seconds, 14.000 MB memory used
➜  chartmogul-php git:(sc-51957/deprecate_old_pagination) ./vendor/bin/php-cs-fixer check src/Http/Retry.php
Loaded config default.
Using cache file ".php-cs-fixer.cache".

@kmossco kmossco merged commit e44fc93 into main Oct 31, 2023
@kmossco kmossco deleted the sc-51957/deprecate_old_pagination branch October 31, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants