Update rollup and add ESM output #17
Conversation
|
Resolved the items for review and did some extra cleanup. I'm with you, I don't think those plugins were necessary, just included them for parity with Chart.js' rollup. One thing about the 2.8 vs 3.0 is I'm concerned that folks might mistakenly try to use the esm version with the non-esm-supported chart.js (2.8 said imports were supported, but it didn't work like it does with modules). I dropped it back anyways. Tagged this as a WIP though, because I need to test the esm files produced here, in a live environment, or update the unit tests to test both types. |
|
Is there still work to be done on this? If so, I'm happy to help. ES6 builds would make my life much easier. |
|
Thanks for the Bump @iddings. I simply haven't tried the suggestion of removing the cleanup and babel plugins suggested above (short on free time and lost track). I'll give it a quick update. |
|
Addressed the last few items, should be good to go now 👍 |
* Update rollup and add ESM output (#17) Update rollup and add ESM output * Update README with latest version (#15) * Remove bower (#19) * Remove use of helpers for v3 compatibility (#20) * Fix startOf function for isoWeek (#23) Fix startOf function for isoWeek * Bump version to 0.2.2 (#21) Co-authored-by: Colin Griffin <colin@krum.io> Co-authored-by: stockiNail <stocki.nail@gmail.com>
Update rollup and add ESM output
This updates the rollup config to have some parity with the updated chart.js rollup config, and also adds ESM output.
A unit test needs to be updated, but a fix is available already in #12
This also updates the chartjs version like #12depends on #12closes #16