Restore datasets namespace (revert 6955)
#8090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etimberg
previously approved these changes
Nov 21, 2020
9c18a82 to
9852c35
Compare
etimberg
approved these changes
Nov 24, 2020
I think it might be better to do that in a separate PR. Lets wait for SB to review this too. |
simonbrunel
approved these changes
Nov 24, 2020
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8073
Datasets options are now created from (bar for example):
defaults.controllers.bar.datasets,options.datasets.bar,data.datasetsThe
defaults.controllers.bar.datasetsseems suspect. Its there because a controller needs to be able to provide chart level defaults and dataset level defaults. To align things , we could move the per controller dataset defaults todefaults.datasets[type]and keepdefaults.controllers[type]as chart level controller defaults.Thoughts?