Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flat helpers #7806

Merged
merged 6 commits into from
Sep 28, 2020
Merged

flat helpers #7806

merged 6 commits into from
Sep 28, 2020

Conversation

sgratzl
Copy link
Contributor

@sgratzl sgratzl commented Sep 18, 2020

closes #7750

breaking change:

  • bundle the helpers in a flat format in both UMD and ESM case.
  • create a helpers package that exports the helpers in commonjs and esm format

please test

@sgratzl sgratzl mentioned this pull request Sep 18, 2020
Closed
kurkle
kurkle reviewed Sep 20, 2020
View reviewed changes
Copy link
Member

@kurkle kurkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Need to update the migration guide too.

etimberg
etimberg previously approved these changes Sep 20, 2020
View reviewed changes
@etimberg etimberg mentioned this pull request Sep 22, 2020
Closed
@etimberg
Copy link
Member

@sgratzl would you be able to update the migration guide? Then we can merge this

@sgratzl
Copy link
Contributor Author

sgratzl commented Sep 27, 2020

done

kurkle
kurkle approved these changes Sep 28, 2020
View reviewed changes
Copy link
Member

@kurkle kurkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@etimberg etimberg merged commit 391e4b6 into chartjs:master Sep 28, 2020
@etimberg etimberg added this to the Version 3.0 milestone Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etimberg etimberg etimberg approved these changes

@kurkle kurkle kurkle approved these changes

Assignees
No one assigned
Labels
type: documentation
Projects
None yet
Milestone
Version 3.0
Development

Successfully merging this pull request may close these issues.

to discuss: flat export of helpers in main chart.js
3 participants
@sgratzl @etimberg @kurkle