Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move location of dataset options #6955

Merged
merged 2 commits into from
Jan 14, 2020
Merged

Conversation

benmccann
Copy link
Contributor

As suggested by @stockiNail in #6684

It has seemed to cause problems for several people who were extending charts that they needed to configure options in two places. This would fix that. See the change to docs/developers/charts.md

@benmccann benmccann mentioned this pull request Jan 13, 2020
3 tasks
Copy link
Member

@kurkle kurkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks a bit weird in that order, but its better for extensions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants