Controller Driven Charts #1219
Merged
Controller Driven Charts #1219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed `Chart.Type.extend` to put the parent's prototype in __super__. Moved more code into the controller and renamed the controller to RectangularElementController.
…roller that goes along with the element controller.
…ed 'chart' to 'chartInstance' in the controllers
Chart controller, Dataset Controllers, Hybrid Charts
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Charts are now instances of a core controller and utilize dataset controllers to visualize different styles of data on the same chart area (assuming scale compatibility).