Specify module for Webpack 4

[ankane]

Hi, thanks for this project!

Webpack 4 currently loads ./dist/chart.cjs since it doesn't support exports: webpack/webpack#9509

[ankane]

Looks like it was broken by #11033 (which switched main)

[dangreen]

@ankane Hi. Thank you for the PR.

main field contains bundle suitable for nodejs

i'm ok with these changes, but this problem is relevant only for webpack <= 4 and can be solved by using this plugin

[etimberg]

This seems ok, but I am a bit wary of all these changes in the package.json file. It seems like the bundler ecosystem is so fragmented that finding a solution that works for everyone is impossible.

[kurkle]

This seems ok, but I am a bit wary of all these changes in the package.json file. It seems like the bundler ecosystem is so fragmented that finding a solution that works for everyone is impossible.

I think one mistake was to change anything else than adding the exports. Old stuff does not read the exports at all, and we had things working quite well.

[ankane]

Thanks everyone!

[dangreen]

@etimberg @kurkle @LeeLenaleee Hi. How about to make bugfix release with it?

[kurkle]

I think @LeeLenaleee suggested in slack, that it should be 4.2 because package.json changed. But I'd be fine releasing this kind of change as a bug fix.

[stockiNail]

@kurkle @LeeLenaleee @dangreen @etimberg this PR should also solve another issue opened in annotation plugin (chartjs/chartjs-plugin-annotation#831). Maybe this PR could be marked as "chore" in order to have an evidence in the release note. I'm just thinking loud.

[stockiNail]

Thank you @kurkle

[Sokhongg]

[Sokhongg]

can anyone one solve this problem I spend almost 4hours to fix this and still no clue thanks.

[dangreen]

@Sokhongg you should transpile dependencies with babel

https://dev.to/cubejs/why-and-how-to-transpile-dependencies-of-your-javascript-application-3phf