feat: parse level from string #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caarlos0
reviewed
Feb 22, 2023
caarlos0
reviewed
Feb 22, 2023
caarlos0
reviewed
Feb 22, 2023
caarlos0
reviewed
Feb 22, 2023
added 4 commits
February 23, 2023 00:21
* Fixes charmbracelet#9. * With these changes, the log level will be able to read from the env var with `LOG_LEVEL` key. Signed-off-by: Gökhan Özeloğlu <gokhan.ozeloglu@deliveryhero.com>
* Update .gitignore. Signed-off-by: Gökhan Özeloğlu <gokhan.ozeloglu@deliveryhero.com>
* `readLevelFromEnv` function is removed. * Tests updated. Signed-off-by: Gökhan Özeloğlu <gokhan.ozeloglu@deliveryhero.com>
* This function converts string to Level type. * Unit test implemented. Signed-off-by: Gökhan Özeloğlu <gokhan.ozeloglu@deliveryhero.com>
395864a to
06f692b
Compare
* Replace swich-case blocks with `ParseLevel` function in `WithLevelFromString`. Signed-off-by: Gökhan Özeloğlu <gokhan.ozeloglu@deliveryhero.com>
Signed-off-by: Gökhan Özeloğlu <gokhan.ozeloglu@deliveryhero.com>
caarlos0
reviewed
Feb 23, 2023
caarlos0
reviewed
Feb 23, 2023
aymanbagabas
requested changes
Feb 23, 2023
log_test.go
Outdated
| @@ -2,20 +2,23 @@ package log | |||
|
|
|||
| import ( | |||
| "bytes" | |||
| "os" | |||
| "strings" | |||
| "testing" | |||
|
|
|||
| "github.com/stretchr/testify/assert" | |||
| ) | |||
|
|
|||
| func TestSubLogger(t *testing.T) { | |||
There was a problem hiding this comment.
I think the changes here should be in their own separate test TestParseLevel
|
@gozeloglu could you squash the commits into a single one? |
added 2 commits
February 23, 2023 23:15
* Revert changes in `log_test.go`. * Update test cases in `level_test.go`. Signed-off-by: Gökhan Özeloğlu <gokhan.ozeloglu@deliveryhero.com>
Signed-off-by: Gökhan Özeloğlu <gokhan.ozeloglu@deliveryhero.com>
Cannot you squash the commit when you merge the PR? I think it is possible. If I have to do that, I need to search a little bit. I don't know the command(s) for squashing the commits. |
caarlos0
reviewed
Feb 24, 2023
level_test.go
Outdated
Comment on lines
66
to
70
| if tc.envVarLevel != "" { | ||
| t.Setenv("LOG_LEVEL", tc.envVarLevel) | ||
| lvl = ParseLevel(os.Getenv("LOG_LEVEL")) | ||
| } else { | ||
| lvl = ParseLevel(tc.level) |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
caarlos0
reviewed
Feb 24, 2023
level_test.go
Outdated
| testCases := []struct { | ||
| name string | ||
| level string | ||
| envVarLevel string |
There was a problem hiding this comment.
not needed anymore, as per previous comment
caarlos0
reviewed
Feb 24, 2023
level_test.go
Outdated
Comment on lines
65
to
72
| var lvl Level | ||
| if tc.envVarLevel != "" { | ||
| t.Setenv("LOG_LEVEL", tc.envVarLevel) | ||
| lvl = ParseLevel(os.Getenv("LOG_LEVEL")) | ||
| } else { | ||
| lvl = ParseLevel(tc.level) | ||
| } | ||
| assert.Equal(t, tc.expLevel, lvl) |
There was a problem hiding this comment.
we don't need to test envs anymore, as the main lib does nothing with them
this can be:
Suggested change
| var lvl Level | |
| if tc.envVarLevel != "" { | |
| t.Setenv("LOG_LEVEL", tc.envVarLevel) | |
| lvl = ParseLevel(os.Getenv("LOG_LEVEL")) | |
| } else { | |
| lvl = ParseLevel(tc.level) | |
| } | |
| assert.Equal(t, tc.expLevel, lvl) | |
| assert.Equal(t, tc.expLevel, ParseLevel(tc.level)) |
added 2 commits
February 24, 2023 08:37
Signed-off-by: Gökhan Özeloğlu <gokhan.ozeloglu@deliveryhero.com>
Signed-off-by: Gökhan Özeloğlu <gokhan.ozeloglu@deliveryhero.com>
caarlos0
approved these changes
Feb 24, 2023
Codecov Report
@@ Coverage Diff @@
## main #11 +/- ##
==========================================
+ Coverage 51.02% 51.40% +0.37%
==========================================
Files 22 23 +1
Lines 684 714 +30
==========================================
+ Hits 349 367 +18
- Misses 319 331 +12
Partials 16 16
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
I updated it. Thanks. |
caarlos0
approved these changes
Feb 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR,
ParseLevelfunction is added. It converts the level in string type toLeveltype. Default level is set toINFOlevel.