-
Notifications
You must be signed in to change notification settings - Fork 846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: expose the renderer interface #1094
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aymanbagabas
force-pushed
the
custom-renderer
branch
from
August 19, 2024 19:36
68a8b77
to
7b174bc
Compare
aymanbagabas
force-pushed
the
custom-renderer
branch
2 times, most recently
from
August 19, 2024 21:03
ac75d33
to
28b8d7e
Compare
caarlos0
reviewed
Aug 20, 2024
caarlos0
approved these changes
Aug 20, 2024
This adds the ability to use a custom renderer using a modified version of the existing `renderer` interface.
This moves the GetSize call after initializing the renderer.
aymanbagabas
force-pushed
the
custom-renderer
branch
from
August 20, 2024 16:19
3cb85b4
to
0825f61
Compare
Use Render instead of Write/WriteString
Only disable enabled capabilities. Keep track of mouse mode state.
caarlos0
approved these changes
Aug 20, 2024
Use Mode/SetMode instead of EnableAltScreenBuffer/DisableAltScreenBuffer etc. This uses less code and makes it more usable in the future to accommodate for more terminal capabilities and modes.
caarlos0
approved these changes
Aug 21, 2024
aymanbagabas
force-pushed
the
custom-renderer
branch
from
August 21, 2024 20:04
376737e
to
356c649
Compare
meowgorithm
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to use a custom renderer using a modified version of the existing
renderer
interface. This also keeps track of enabled capabilities and ensure they are turned off on program exit. It only turns off enabled capabilities rather.The new API looks like:
This also introduces some performance gains by not writing unnecessary sequences on enable/disable terminal modes. For example, we always hide the cursor when the program runs, it doesn't make sense to write the sequence again when the model sends a
HideCursor
command, we already know it's hidden. Don't always disable mouse if it wasn't enabled in the first place.