feat: support setting and querying the terminal clipboard using OSC52 #1086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support to setting the system and primary (X11 & Wayland) clipboards using OSC52. This makes the clipboard commands work even on remote session such as SSH. While this doesn't work on all terminals, most modern terminals support OSC52 including Alacritty, Kitty, Xterm.JS, etc. For terminals, that don't support OSC52, application developers should consider using a Golang clipboard library like https://github.com/atotto/clipboard. OSC52 support can be detected if the terminal responds to a `ReadClipboard` command. Fixes: #982
b97ffd7 to
04f843d
Compare
caarlos0
reviewed
Aug 15, 2024
| @@ -581,15 +581,28 @@ func parseOsc(b []byte) (int, Msg) { | |||
| if len(parts) == 0 { | |||
| return i, ClipboardMsg("") | |||
| } | |||
| b64 := parts[len(parts)-1] | |||
| if len(parts) != 2 { | |||
There was a problem hiding this comment.
maybe use strings.Cut? not sure if it existed in 1.18 or only earlier version
There was a problem hiding this comment.
But we also want to ensure that we exactly have 2 parts, strings.Cut will only split on the first occurrence of ;.
caarlos0
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support to setting the system and primary (X11 & Wayland) clipboards using OSC52. This makes the clipboard commands work even on remote session such as SSH.
While this doesn't work on all terminals, most modern terminals support OSC52 including Alacritty, Kitty, Xterm.JS, etc. For terminals, that don't support OSC52, application developers should consider using a Golang clipboard library like https://github.com/atotto/clipboard.
OSC52 support can be detected if the terminal responds to a
ReadClipboardcommand.Fixes: #982