Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: progress: return Model instead of tea.Model #719

Merged
merged 1 commit into from
Jan 29, 2025
Merged

refactor: progress: return Model instead of tea.Model #719

merged 1 commit into from
Jan 29, 2025

Conversation

aymanbagabas
Copy link
Member

This conforms to the new generic bubbletea API.
See charmbracelet/bubbletea#1298

meowgorithm
meowgorithm approved these changes Jan 29, 2025
View reviewed changes
Copy link
Member

@meowgorithm meowgorithm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I also made this change in v2-generics.

@aymanbagabas aymanbagabas merged commit a0d9fe3 into v2-exp Jan 29, 2025
22 of 26 checks passed
@aymanbagabas aymanbagabas deleted the v2-progress branch January 29, 2025 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meowgorithm meowgorithm meowgorithm approved these changes

@caarlos0 caarlos0 Awaiting requested review from caarlos0

@bashbunni bashbunni Awaiting requested review from bashbunni

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aymanbagabas @meowgorithm