Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Charge Control C: add section regarding phase count switching support #29

Open
wants to merge 2 commits into
base: everest/charge_control_c
Choose a base branch
from

Conversation

mhei
Copy link
Member

@mhei mhei commented Jan 14, 2025

No description provided.

Signed-off-by: Michael Heimpold <michael.heimpold@chargebyte.com>
Copy link

@t-mon t-mon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise lgtm, I actually don't see the diff in most pictures here, but that also could be the pr-review view. Have all those images changed?

docs/source/everest_charging_stack.rst Outdated Show resolved Hide resolved
@mhei
Copy link
Member Author

mhei commented Jan 14, 2025

Otherwise lgtm, I actually don't see the diff in most pictures here, but that also could be the pr-review view. Have all those images changed?

No, I just adjusted the permissions.

@mhei mhei force-pushed the everest/charge_control_c-switch-3ph1ph branch from d2ccd0d to 9199262 Compare January 14, 2025 12:13
docs/source/everest_charging_stack.rst Outdated Show resolved Hide resolved
* **none** (default): No phase-count switching is supported - only R1/S1 is used to switch on/off a single contactor.
* **serial**: Phase-count switching support is enabled using the serial wiring as described above: R1/S1 switches
the primary contactor, R2/S2 is attached to the secondary contactor.
* **mutual**: Phase-count switching support is enabled using the mutual wiring as described above. R1/S1 is wired to
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"mutual" is currently not supported or? We should mention it in the documentation.

docs/source/everest_charging_stack.rst Outdated Show resolved Hide resolved
Signed-off-by: Michael Heimpold <michael.heimpold@chargebyte.com>
@mhei mhei force-pushed the everest/charge_control_c-switch-3ph1ph branch from 9199262 to f8654be Compare January 17, 2025 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants