feature(#174): add omitIndexes #180
Conversation
562a6aa to
3af8d6f
Compare
|
@BjornMelgaard What about this version ? const { contains, curry, addIndex, reject } = require('ramda');
// helpers
const rejectIndexed = addIndex(reject);
const containsIndex = curry((indexes, val, index) => contains(index, indexes));
const omitIndexes = curry((indexes, list) => rejectIndexed(containsIndex(indexes), list));Seems more declarative, easier to read and predicate function creation is hidden inside currying and not exposed to business logic. |
|
@char0n yes, like it very much |
2d43ad1 to
299c257
Compare
src/omitIndexes.js
Outdated
| * | ||
| * RA.omitIndexes([-1, 1, 3], ['a', 'b', 'c', 'd']); //=> ['a', 'c'] | ||
| */ | ||
|
|
There was a problem hiding this comment.
Pls move rejectIndexed and containsIndex before the jsdoc to that jsdoc is applied directly to omitIndexes and not to rejectIndexed.
| const expected = ['a', 'c']; | ||
|
|
||
| eq(RA.omitIndexes(indexes, arr), expected); | ||
| }); |
There was a problem hiding this comment.
Pls add tests for 3 more usecases:
- empty indexes (will return unmodified list)
- empty list (will return empty list)
- combination of empty list and empty indexes
Just to be sure we have corner cases covered. I will adjust pickIndexes in #181 to be consistent with your omitIndexes.
Then we can merge.
|
@char0n done |
src/index.d.ts
Outdated
| * Returns a partial copy of an array omitting the indexes specified. | ||
| */ | ||
| omitIndexes<T>(indexes: number[], list: Array<T>): Array<T>; | ||
| omitIndexes(indexes: number): <T>(list: Array<T>) => Array<T>; |
There was a problem hiding this comment.
should this be indexes: number[] ?
src/omitIndexes.js
Outdated
| * | ||
| * @func omitIndexes | ||
| * @memberOf RA | ||
| * @since {@link https://char0n.github.io/ramda-adjunct/1.18.1|v1.18.1} |
There was a problem hiding this comment.
We're at 1.19.0. You can always find the next version inside package.json.
5f2b439 to
da41285
Compare
|
@char0n done |
|
@char0n thanks) |
No description provided.