Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(replaceAll): make tests consistent with other string functions #1141

Merged
merged 2 commits into from
Oct 31, 2019
Merged

test(replaceAll): make tests consistent with other string functions #1141

merged 2 commits into from
Oct 31, 2019

Conversation

char0n
Copy link
Owner

@char0n char0n commented Oct 23, 2019

Ref #878

@char0n
Copy link
Owner Author

char0n commented Oct 23, 2019

@js636f FYI just made some consistency cleanup in tests.

@char0n char0n added the Hacktoberfest Hacktoberfest 2020 label Oct 23, 2019
@js636f
Copy link
Collaborator

js636f commented Oct 23, 2019

@char0n, OK, thanks for the info.

@char0n char0n mentioned this pull request Oct 31, 2019
Open
@char0n char0n merged commit c511d00 into master Oct 31, 2019
@char0n char0n deleted the char0n/replaceAll-test branch November 1, 2019 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Hacktoberfest Hacktoberfest 2020
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@char0n @js636f