Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(replaceAll): add TC39 proposal-compliant String.replaceAll ponyfill to use in RA.replaceAll #1124

Merged
merged 13 commits into from
Oct 23, 2019
Merged

fix(replaceAll): add TC39 proposal-compliant String.replaceAll ponyfill to use in RA.replaceAll #1124

merged 13 commits into from
Oct 23, 2019

Conversation

js636f
Copy link
Collaborator

@js636f js636f commented Oct 16, 2019

No description provided.

@js636f js636f mentioned this pull request Oct 16, 2019
Closed
@char0n char0n added the Hacktoberfest Hacktoberfest 2020 label Oct 19, 2019
@char0n
Copy link
Owner

char0n commented Oct 21, 2019

I'm rerunning failed tests for node 9. Doing CR now. Thank you!

@char0n char0n self-requested a review October 21, 2019 06:50
char0n
char0n requested changes Oct 21, 2019
View reviewed changes
Copy link
Owner

@char0n char0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice work here! Please have a look at my code review comments before we move forward.

char0n
char0n requested changes Oct 22, 2019
View reviewed changes
Copy link
Owner

@char0n char0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be last round. 3 comments to process and we're good to go for a merge. Thank you!

@js636f js636f force-pushed the replaceAllPonyFill branch from f4cca77 to 9e329a4 Compare October 22, 2019 07:49
char0n
char0n approved these changes Oct 23, 2019
View reviewed changes
Copy link
Owner

@char0n char0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're good to go here. Excellent work and thank you for your contribution!

@char0n char0n merged commit 74d5163 into char0n:master Oct 23, 2019
@js636f
Copy link
Collaborator Author

js636f commented Oct 23, 2019

@char0n, I'm happy to help! Thank you for your support!

@js636f js636f deleted the replaceAllPonyFill branch October 23, 2019 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@char0n char0n char0n approved these changes

Assignees
No one assigned
Labels
Hacktoberfest Hacktoberfest 2020
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@js636f @char0n