Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for ramda 0.24.0 #86

Closed
char0n opened this issue May 30, 2017 · 7 comments
Closed

Support for ramda 0.24.0 #86

char0n opened this issue May 30, 2017 · 7 comments

Comments

@char0n
Copy link
Owner

char0n commented May 30, 2017

No description provided.

@char0n char0n self-assigned this May 30, 2017
@char0n
Copy link
Owner Author

char0n commented Jun 9, 2017

Constrain peerDep from >= 19 <= 0.24.0

@char0n
Copy link
Owner Author

char0n commented Jun 11, 2017

High priority.

@char0n char0n added the feature label Jun 11, 2017
@char0n
Copy link
Owner Author

char0n commented Jun 12, 2017

0.24.1

@rockymadden
Copy link
Collaborator

rockymadden commented Jun 14, 2017

When running against version 0.24.1, I was getting:

/Users/rockymadden/Documents/bodenstein/node_modules/ramda/src/internal/_dispatchable.js:29
        if (typeof obj[methodNames[idx]] === 'function') {
                      ^

TypeError: Cannot read property 'fantasy-land/map' of undefined
    at /Users/rockymadden/Documents/bodenstein/node_modules/ramda/src/internal/_dispatchable.js:29:23
    at f2 (/Users/rockymadden/Documents/bodenstein/node_modules/ramda/src/internal/_curry2.js:25:16)
    at /Users/rockymadden/Documents/bodenstein/node_modules/ramda/src/liftN.js:28:24
    at f1 (/Users/rockymadden/Documents/bodenstein/node_modules/ramda/src/internal/_curry1.js:17:17)
    at Object.<anonymous> (/Users/rockymadden/Documents/bodenstein/node_modules/ramda-adjunct/lib/isNotArrayLike.js:26:44)
    at Module._compile (module.js:569:30)
    at Module._extensions..js (module.js:580:10)
    at extensions.(anonymous function) (/Users/rockymadden/Documents/bodenstein/node_modules/require-precompiled/index.js:16:3)
    at Object.require.extensions.(anonymous function) [as .js] (/Users/rockymadden/Documents/bodenstein/node_modules/ava/lib/process-adapter.js:100:4)
    at Module.load (module.js:503:32)
    at tryModuleLoad (module.js:466:12)
    at Function.Module._load (module.js:458:3)
    at Module.require (module.js:513:17)
    at require (internal/module.js:11:18)
    at Object.<anonymous> (/Users/rockymadden/Documents/bodenstein/node_modules/ramda-adjunct/lib/index.js:123:23)
    at Module._compile (module.js:569:30)
    at Module._extensions..js (module.js:580:10)
    at extensions.(anonymous function) (/Users/rockymadden/Documents/bodenstein/node_modules/require-precompiled/index.js:16:3)
    at Object.require.extensions.(anonymous function) [as .js] (/Users/rockymadden/Documents/bodenstein/node_modules/ava/lib/process-adapter.js:100:4)
    at Module.load (module.js:503:32)
    at tryModuleLoad (module.js:466:12)
    at Function.Module._load (module.js:458:3)
    at Module.require (module.js:513:17)
    at require (internal/module.js:11:18)
    at Object.<anonymous> (/Users/rockymadden/Documents/bodenstein/test/lib/core.js:5:46)
    at Module._compile (module.js:569:30)
    at extensions.(anonymous function) (/Users/rockymadden/Documents/bodenstein/node_modules/require-precompiled/index.js:13:11)
    at Object.require.extensions.(anonymous function) [as .js] (/Users/rockymadden/Documents/bodenstein/node_modules/ava/lib/process-adapter.js:100:4)
    at Module.load (module.js:503:32)
    at tryModuleLoad (module.js:466:12)
    at Function.Module._load (module.js:458:3)
    at Module.require (module.js:513:17)
    at require (internal/module.js:11:18)
    at Object.<anonymous> (/Users/rockymadden/Documents/bodenstein/node_modules/ava/lib/test-worker.js:49:1)
    at Module._compile (module.js:569:30)
    at Object.Module._extensions..js (module.js:580:10)
    at Module.load (module.js:503:32)
    at tryModuleLoad (module.js:466:12)
    at Function.Module._load (module.js:458:3)
    at Function.Module.runMain (module.js:605:10)
    at startup (bootstrap_node.js:158:16)
    at bootstrap_node.js:575:3

From simply importing:

const {isArray, isNotEmpty, isPlainObject} = require('ramda-adjunct');

char0n added a commit that referenced this issue Jun 14, 2017
@char0n
Copy link
Owner Author

char0n commented Jun 14, 2017

@rockymadden working on it.

@char0n char0n closed this as completed in b414d1c Jun 14, 2017
@char0n
Copy link
Owner Author

char0n commented Jun 14, 2017

@rockymadden released v1.9.0 that adds support for 0.24.0 and 0.24.1 - https://www.npmjs.com/package/ramda-adjunct

@rockymadden
Copy link
Collaborator

Thank you very much, @char0n!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants