Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RA doesn't include latest version of R in peerDependencies range #745

Closed
Undistraction opened this issue Nov 22, 2018 · 5 comments
Closed

Comments

@Undistraction
Copy link
Collaborator

The README says:

ramda >= 0.19.0

But in the package.json

"peerDependencies": {
    "ramda": ">= 0.19.0 <= 0.25.0"
  },

The current version of Ramda is 0.26.0, so updating to the latest version of Ramda in a project using Ramda Adjunct results in:

npm WARN ramda-adjunct@2.11.0 requires a peer of ramda@>= 0.19.0 <= 0.25.0 but none is installed. You must install peer dependencies yourself.

@Undistraction Undistraction changed the title RA doesn't include latest version of Ramda in range RA doesn't include latest version of R in peerDependencies range Nov 22, 2018
@char0n
Copy link
Owner

char0n commented Nov 22, 2018

Yes and that is correct. We haven't tested newest version of ramda@0.26.0 yet and there is pending PR for it here #738. All our tests are failing, so I suppose something must have changed and we should compensate.

@char0n
Copy link
Owner

char0n commented Nov 22, 2018

If you have time feel free to take over this one.

@Undistraction
Copy link
Collaborator Author

OK. But the README Is incorrect then. It should have an upper limit on the supported range:

ramda >= 0.19.0

@char0n
Copy link
Owner

char0n commented Nov 22, 2018

Agree it's incorrect. I forgot to translate the peerDeps rules there.

@char0n char0n self-assigned this Nov 25, 2018
char0n added a commit that referenced this issue Nov 25, 2018
char0n added a commit that referenced this issue Nov 25, 2018
char0n added a commit that referenced this issue Nov 25, 2018
@char0n
Copy link
Owner

char0n commented Nov 25, 2018

Resolved by referenced commits and v2.12.0 release.

@char0n char0n closed this as completed Nov 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants