Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cata #58

Closed
char0n opened this issue Apr 20, 2017 · 3 comments
Closed

cata #58

char0n opened this issue Apr 20, 2017 · 3 comments
Assignees
@char0n
Labels
feature

Comments

@char0n
Copy link
Owner

char0n commented Apr 20, 2017

Catamorphism monad bridge
@char0n char0n added the feature label Apr 20, 2017
@char0n char0n self-assigned this Apr 20, 2017
@char0n char0n closed this as completed in 1c6fdc6 Apr 27, 2017
@char0n
Copy link
Owner Author

char0n commented Apr 27, 2017

@tycho01 could you please review the typings if you'll have couple of minutes to spare. I've added some more complex declarations.

ramda-adjunct/src/index.d.ts

Line 260 in 1c6fdc6

cata<V1, V2, T1, T2>(leftFn: (leftValue: V1) => T1, rightFn: (rightValue: V2) => T2, either: Catamorphism<V1|V2>): T1|T2;

Thank you

char0n added a commit that referenced this issue Apr 27, 2017
@char0n
test(cata): add tests for non catamorphic monads
905dc4f 
Ref #58
char0n added a commit that referenced this issue Apr 27, 2017
@char0n
docs(cata): add proper jsdocs
4fdcb34 
Ref #58
@KiaraGrouwstra
Copy link
Contributor

Without having tested them, I think that looks okay. I'm still less confident about the ADTs as defined in Ramda as well, also see here.

@char0n
Copy link
Owner Author

char0n commented Apr 29, 2017

Thanks for your time mate. Will look at the link.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@char0n char0n

Labels
feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@char0n @KiaraGrouwstra