Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eslint: rule for empty lines between imorts #377

Closed
guillaumearm opened this issue Feb 18, 2018 · 0 comments · Fixed by #378
Closed

eslint: rule for empty lines between imorts #377

guillaumearm opened this issue Feb 18, 2018 · 0 comments · Fixed by #378
Assignees
@guillaumearm
Labels
enhancement

Comments

@guillaumearm
Copy link
Collaborator

Like said in review of #375, I think eslint should check for empty lines between relative and absolute imports.

There exists a newlines-between option for eslint import/order rule.

PR is coming very soon.
@guillaumearm guillaumearm self-assigned this Feb 18, 2018
guillaumearm added a commit that referenced this issue Feb 18, 2018
@guillaumearm
style(eslint): add newlines-between option to import/order rule
e91de6e 
+ fix errors according to new eslint rules

Closes #377
guillaumearm added a commit that referenced this issue Feb 18, 2018
@guillaumearm
style(eslint): add newlines-between option to import/order rule
ba68cb8 
+ fix errors according to this new eslint rules (in 5 tests files)

Closes #377
@guillaumearm guillaumearm mentioned this issue Feb 18, 2018
Merged
char0n pushed a commit that referenced this issue Feb 19, 2018
@guillaumearm @char0n
style(eslint): add newlines-between option to import/order rule
2f5173a 
+ fix errors according to this new eslint rules (in 5 tests files)

Closes #377
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@guillaumearm guillaumearm

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

style(eslint): add newlines-between option to import/order rule char0n/ramda-adjunct
1 participant
@guillaumearm