Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Absorb ramda cookbook #27

Closed
char0n opened this issue Feb 23, 2017 · 7 comments
Closed

Absorb ramda cookbook #27

char0n opened this issue Feb 23, 2017 · 7 comments
Assignees
Labels

Comments

@char0n
Copy link
Owner

char0n commented Feb 23, 2017

https://github.com/ramda/ramda/wiki/Cookbook

@char0n
Copy link
Owner Author

char0n commented Apr 4, 2017

@tycho01 can you pls check if I got the typescript for pickIndexes right ?

Thanks a lot

@KiaraGrouwstra
Copy link
Contributor

Note that R.props can do exactly that, though unfortunately their documentation is lacking an example for the array case, instead demonstrating its use with an object for input.

Your typing here is consistent with the current one we had for props, though that one is generalized for both arrays and objects as input. A step enabling better type inference for tuples would involve overloading so as to separately pick out each separate item. That was still marked todo for props as well.

@char0n
Copy link
Owner Author

char0n commented Apr 5, 2017

@tycho01 thanks for review. Do you think it makes sense to keep it in codebase if props can handle this usecase ?

@KiaraGrouwstra
Copy link
Contributor

Well, I'm seeing a more general trend between Ramda and Adjunct in generic vs. specific. In that sense, I think it's consistent with the functions already part of Adjunct.

@char0n
Copy link
Owner Author

char0n commented Apr 5, 2017

I tend to agree. Let's keep it in. Thanks for your opinion

@KiaraGrouwstra
Copy link
Contributor

KiaraGrouwstra commented Apr 5, 2017 via email

char0n added a commit that referenced this issue Apr 8, 2017
char0n added a commit that referenced this issue Apr 14, 2017
char0n added a commit that referenced this issue Apr 14, 2017
char0n added a commit that referenced this issue Apr 15, 2017
char0n added a commit that referenced this issue May 5, 2017
char0n added a commit that referenced this issue May 8, 2017
@rockymadden rockymadden mentioned this issue Oct 19, 2017
@char0n
Copy link
Owner Author

char0n commented Dec 24, 2019

I'm doing a full review now and will create separate issues for every function we may implement.

@char0n char0n closed this as completed Dec 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants