Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RA.isTrue, RA.isFalse #255

Closed
char0n opened this issue Dec 24, 2017 · 11 comments
Closed

RA.isTrue, RA.isFalse #255

char0n opened this issue Dec 24, 2017 · 11 comments
Assignees
Labels
Milestone

Comments

@char0n
Copy link
Owner

char0n commented Dec 24, 2017

Don't forget to refactor code that now uses constructs like

equals(true)
equals(false)
@rockymadden
Copy link
Collaborator

I can grab this one, have it in a handful of private repos that I can then leverage against.

@char0n
Copy link
Owner Author

char0n commented Jan 2, 2018

Go for it... don't forget to process 1st comment of this issue though

@rockymadden
Copy link
Collaborator

Yep, got it.

@char0n
Copy link
Owner Author

char0n commented Jan 9, 2018

@rockymadden will you be able to squeeze something at least of them in for v2.3.0 release ?

@rockymadden
Copy link
Collaborator

rockymadden commented Jan 10, 2018

@char0n Yep, I can get that done by the 14th.

@rockymadden
Copy link
Collaborator

rockymadden commented Jan 13, 2018

@char0n Family and work has come up. I will not be able to finish by tomorrow.

@char0n
Copy link
Owner Author

char0n commented Jan 14, 2018 via email

@Undistraction
Copy link
Collaborator

Undistraction commented Jan 15, 2018

If we had this in we could also add propIsTrue and propIsFalse. Basically:

const propIsTrue = propSatisfies(isTrue)
const propIsFalse = propSatisfies(isFalse)

But I guess if we go down that road then where do we stop? propIsArray, propIsString etc

@char0n
Copy link
Owner Author

char0n commented Jan 16, 2018

@Undistraction I would go this way if we find enough usecases in our codebases. If there are no usecases for us at this moment (I don't have one now) I'd rather wait for somebody to request it or for us having a usecases for it.

@char0n char0n added this to the v2.4.0 milestone Jan 16, 2018
@char0n
Copy link
Owner Author

char0n commented Jan 16, 2018

@rockymadden assigned this to v2.4.0 milestone. Let's see if we manage to implement at least one of them ;]

@Undistraction
Copy link
Collaborator

@rockymadden You OK if I pick this up?

@Undistraction Undistraction modified the milestones: v2.5.0, 2.6.0 Feb 16, 2018
@Undistraction Undistraction changed the title isTrue, isFalse RA.isTrue, RA.isFalse Feb 21, 2018
char0n pushed a commit that referenced this issue Mar 14, 2018
 - use `isTrue` and `isFalse` in lib
 - fix lensSatisfies example

Closes #255
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants