Valid Number

[Undistraction]

Would you accept a PR for a Sanctary-style isValidNumber()?

Effectively:

const isValidNumber = both(isNumber, complement(isNaN));

[char0n]

We would, but need to understand first the usecases.

I can imagive having isValidNumber in the following form

const isValidNumber = R.either(RA.isFloat, RA.isInteger);

In ramda-adjunct we already have isFloat and isInteger. I would expect ValidNumber to be something that is not NaN and also not an Infinite number (+/-Infinity)

[Undistraction]

I would expect ValidNumber to be something that is not NaN and also not an Infinite number (+/-Infinity)

That's a fair point. I agree.

[char0n]

@Undistraction go for a PR then.

@BjornMelgaard opinion ?

[srghma]

no

[Undistraction]

no

So is that a no to a PR?

[srghma]

@Undistraction sorry, I meant I have no comments)
Please do it)

[Undistraction]

@BjornMelgaard OK. Thanks. I'll go ahead.

[char0n]

@Undistraction, @BjornMelgaard going for 2.2.0 release after the CI finishes the build for the last commit of this repo. I would specially like to thank @Undistraction for his contributions for this release.

[Undistraction]

@charon Thanks. Was a pleasure. You run a pleasingly tight ship!

[char0n]

@Undistraction thanks good to hear that ;] After you finish #234 and you'll still interesting in contributing further you can become commiter/contributor of this project.

[Undistraction]

Thanks. That would be grand.

[char0n]

v2.2.0 out: https://www.npmjs.com/package/ramda-adjunct