drop TCP Wrappers support + misc. build system cleanup #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: the README, debian control file, and install-deps-deb.sh script mention libpopt, but that was only a requirement for dbench, which we no longer vendor. Drop libpopt references.
Problem: posix requires getopt.h, yet we check for it, and each command line tool falls back to short opts if long opts are unavailable, but support is ubiquitous. Drop the conditional header include, and the short option fallback. If we encounter a place where getopt_long() is missing, we can provide it via libmissing.
Problem: TCP wrappers was useful before operating systems had firewalls, but less so these days. Drop support for TCP Wrappers.
Problem: configure.ac includes checks for vsnprintf(3) and vsscanf(3) but the HAVE_VSNPRINTF and HAVE_VSSCANF preprocessor defines are not used. Drop the checks. These functions have been standardized for some time.
Problem: configure --disable-tests doesn't accomplish anything. Running 'make check' and getting a positive outcome when nothing was run is misleading. The right thing to do is to skip individual tests when features are de-selected. For now just remove this configure option.
Problem: logic for platform defaults in configure.ac is a bit complex. Drop the platform-specific logic that to set --disable-diodmount on FreeBSD. Those building server-only FreeBSD diod installations (if there still are any!) can specify that option explicitly.
09de2ff to
cf4bfac
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This drops support for the antiquated TCP Wrappers package.
It also tidies up some other quaint stuff like conditional support for long options.
Finally, some configure options added for niche use cases are simplified/removed.