forked from kubernetes/test-infra
-
Notifications
You must be signed in to change notification settings - Fork 2
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Prow jobs respect default entrypoints
Supercedes kubernetes#25383, where in kubernetes#25383 the logic is in the pod where tests run, the problem there is that imagePullSecret defined on job pod is not accessible, which limits it's use case. The other problem is that the containers inside a test pod are not aware of the image they are from, so it's a little bit weird to let them know about it. This PR moves the logic to plank, which feels more natural ----------------------------- This is an unfortunate fact of prow, that user need to explictly set the entrypoint. The migration of prow images from being built with bazel to ko introduced a side effect of all prow jobs that use gcr.io/k8s-prow images, such as robots/comment, robots/pr-creator etc. would fail due to the location of default entrypoint change. It would be trivial amount of work to update the binary location in prow jobs definition, but would like to use this opportunity to try to get this fixed. (This PR was an effort baked on top of separate offline brainstorming with @cjwagner and @BenTheElder ) (The entrypoint extraction and docker auth parts were mainly from @imjasonh's work at ko-build/ko#581)
- Loading branch information
Showing
6 changed files
with
1,066 additions
and
113 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.