Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(styles/common): add borders to makeSdsSemanticAppTheme util #924

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore(styles/common): add borders to makeSdsSemanticAppTheme util #924

wants to merge 2 commits into from

Conversation

crispipear
Copy link
Contributor

@crispipear crispipear commented Jan 16, 2025 •
edited
Loading

Summary

Structural Element (Base, Gene, DNA, Chromosome or Cell) Base

  • Make borders available in makeSdsSemanticAppTheme util
    • currently it's defined outside of the util and only for the default SDS themes if consumers uses makeSdsSemanticAppTheme, the borders colors object will be undefined in the app theme.
  • Simplify the border colors configuration and remove duplicated lines

Checklist

  • Default Story in Storybook
  • Test Story in Storybook
  • Tests written
  • Semantic Variables from defaultTheme.ts used wherever possible
  • If updating an existing component, depreciate flag has been used where necessary
  • ZeroHeight Documents updated
  • Chromatic build verified by @chanzuckerberg/sds-design

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@crispipear