Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #1

Merged
merged 1 commit into from
Apr 8, 2021
Merged

Update README.md #1

merged 1 commit into from
Apr 8, 2021

Conversation

neuromusic
Copy link
Collaborator

@neuromusic neuromusic commented Apr 2, 2021

Adds some info on goals & roadmap to the README

@neuromusic neuromusic marked this pull request as ready for review April 7, 2021 00:02
Copy link
Contributor

@sofroniewn sofroniewn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I caught a minor typo, added a suggestion about github handles, and softened a little of the language around "bio" - I don't want other scientific users to feel excluded from the hub

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@LCObus LCObus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I had to google LGTM...)
But also looks GREAT to me! Also found some tiny tweaks but I think you captured the important details concisely!

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@neuromusic
Copy link
Collaborator Author

thanks for the feedback @sofroniewn and @LCObus !!

once I get @justinelarsen 's eyes on it & approval, I'll merge

Copy link
Contributor

@justinelarsen justinelarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall @neuromusic ! I added some minor comments that aren't critical but the Team section should definitely be resolved before merging.

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
revisions


info re: future plans


issue templates


build -> built

Co-authored-by: Nicholas Sofroniew <sofroniewn@gmail.com>
bio -> sci

Co-authored-by: Nicholas Sofroniew <sofroniewn@gmail.com>
imaging generally

Co-authored-by: Nicholas Sofroniew <sofroniewn@gmail.com>
grammar fixes

Co-authored-by: Lucy Obus <63607867+LCObus@users.noreply.github.com>
etc.

Co-authored-by: Lucy Obus <63607867+LCObus@users.noreply.github.com>
capitalization

Co-authored-by: Lucy Obus <63607867+LCObus@users.noreply.github.com>
.etc

Co-authored-by: Lucy Obus <63607867+LCObus@users.noreply.github.com>
lowercase

Co-authored-by: Lucy Obus <63607867+LCObus@users.noreply.github.com>
lowercase

Co-authored-by: Lucy Obus <63607867+LCObus@users.noreply.github.com>
team reorg
adds links to user profiles
Team


Update README.md

Co-authored-by: Nicholas Sofroniew <sofroniewn@gmail.com>
justine's edits
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants