Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade storybook to v6.5.8 #1124

Merged
merged 1 commit into from
Jun 10, 2022

Conversation

dierat
Copy link
Contributor

@dierat dierat commented Jun 10, 2022

Summary:

I noticed a buncha console errors in storybook about

The pseudo class ":first-child" is potentially unsafe when doing server-side rendering. Try changing it to ":first-of-type".

It looks like this was fixed in storybook v6.5.8 just a couple days ago:

Unfortunately, upgrading to v6.5.8 in this repo does not completely remove the console error, but it is less annoying.

Screenshots

Before

Screen Shot 2022-06-10 at 3 31 09 PM

After

first-child-console-error

Test Plan:

Load up storybook and verify that error is now collapsed.

@codecov
Copy link

codecov bot commented Jun 10, 2022

Codecov Report

Merging #1124 (c386a33) into next (545610c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             next    #1124   +/-   ##
=======================================
  Coverage   85.75%   85.75%           
=======================================
  Files         156      156           
  Lines        2365     2365           
  Branches      398      398           
=======================================
  Hits         2028     2028           
  Misses        336      336           
  Partials        1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 545610c...c386a33. Read the comment docs.

@dierat dierat marked this pull request as ready for review June 10, 2022 22:38
@dierat dierat requested a review from a team June 10, 2022 22:38
Copy link
Contributor

@jinlee93 jinlee93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, upgrading to v6.5.8 in this repo does not completely remove the console error, but it is less annoying.

I'll take less annoying, thanks!

@dierat dierat merged commit dbd1f96 into next Jun 10, 2022
@dierat dierat deleted the diedra/console-cleanup/upgrade-storybook branch June 10, 2022 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants